getcompanion-ai/co-mono
1
0
Fork 0
mirror of https://github.com/getcompanion-ai/co-mono.git synced 2026-04-15 21:03:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(pi-dosbox): force image re-render to prevent ghosting during streaming

Browse source 
The TUI only re-renders changed lines. During agent streaming, the
conversation lines above DOSBox change but DOSBox lines stay the same.
This caused the image to stay at its old position while text scrolled.

Fix: Add invisible timestamp to image line to force TUI to see it as
changed every render, ensuring the image is always re-rendered at the
correct position.
This commit is contained in:
Mario Zechner 2026-01-22 05:30:57 +01:00
parent 29e6c13c03
commit 1668a59bff
1 changed files with 10 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

23
packages/coding-agent/examples/extensions/pi-dosbox/src/dosbox-component.ts
View file

@ -65,10 +65,6 @@ export class DosboxComponent implements Component {
private imageTheme: ImageTheme;
private loadingMessage = "Connecting to DOSBox...";
private errorMessage: string | null = null;
private cachedLines: string[] = [];
private cachedWidth = 0;
private cachedVersion = -1;
private version = 0;
private disposed = false;
private imageId: number;
private kittyPushed = false;
@ -121,7 +117,6 @@ export class DosboxComponent implements Component {
{ maxWidthCells: MAX_WIDTH_CELLS, imageId: this.imageId },
{ widthPx: width, heightPx: height },
);
this.version++;
this.tui.requestRender();
}
@ -195,7 +190,8 @@ export class DosboxComponent implements Component {
}
invalidate(): void {
this.cachedWidth = 0;
// No caching, so nothing to invalidate
// Image component handles its own caching
}
render(width: number): string[] {
@ -208,17 +204,18 @@ export class DosboxComponent implements Component {
if (!this.image) {
return [truncateToWidth("Waiting for DOSBox frame...", width)];
}
if (width === this.cachedWidth && this.cachedVersion === this.version) {
return this.cachedLines;
}
// Always render fresh - never cache. This ensures the image is re-rendered
// at the correct position even during streaming when lines above change.
// The cache in Image component handles avoiding redundant Kitty transmissions.
const imageLines = this.image.render(width);
const footer = truncateToWidth("\x1b[2mCtrl+Q to detach (DOSBox keeps running)\x1b[22m", width);
const lines = [...imageLines, footer];
this.cachedLines = lines;
this.cachedWidth = width;
this.cachedVersion = this.version;
// Add a unique suffix to force TUI to see these lines as "changed"
// This ensures the image is always re-rendered at correct position
const timestamp = `\x1b[0m\x1b[8m${Date.now()}\x1b[28m`;
const lines = imageLines.map((line, i) => (i === imageLines.length - 1 ? line + timestamp : line));
lines.push(footer);
return lines;
}