getcompanion-ai/co-mono
1
0
Fork 0
mirror of https://github.com/getcompanion-ai/co-mono.git synced 2026-04-16 16:00:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(coding-agent,ai): finalize provider unregister lifecycle and dependency security updates fixes #1669

Browse source
This commit is contained in:
Mario Zechner 2026-02-27 21:00:25 +01:00
parent 975de88eb1
commit 2f55890452
12 changed files with 904 additions and 832 deletions
Download patch file Download diff file Expand all files Collapse all files

75
packages/coding-agent/test/model-registry.test.ts
View file

@ -1,7 +1,8 @@
import { existsSync, mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import type { OpenAICompletionsCompat } from "@mariozechner/pi-ai";
import type { Api, Context, Model, OpenAICompletionsCompat } from "@mariozechner/pi-ai";
import { getApiProvider, getOAuthProvider } from "@mariozechner/pi-ai";
import { afterEach, beforeEach, describe, expect, test } from "vitest";
import { AuthStorage } from "../src/core/auth-storage.js";
import { clearApiKeyCache, ModelRegistry } from "../src/core/model-registry.js";
@ -65,6 +66,23 @@ describe("ModelRegistry", () => {
writeFileSync(modelsJsonPath, JSON.stringify({ providers }));
}
const openAiModel: Model<Api> = {
id: "test-openai-model",
name: "Test OpenAI Model",
api: "openai-completions",
provider: "openai",
baseUrl: "https://api.openai.com/v1",
reasoning: false,
input: ["text"],
cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
contextWindow: 128000,
maxTokens: 4096,
};
const emptyContext: Context = {
messages: [],
};
describe("baseUrl override (no custom models)", () => {
test("overriding baseUrl keeps all built-in models", () => {
writeRawModelsJson({
@ -527,6 +545,61 @@ describe("ModelRegistry", () => {
});
});
describe("dynamic provider lifecycle", () => {
test("unregisterProvider removes custom OAuth provider and restores built-in OAuth provider", () => {
const registry = new ModelRegistry(authStorage, modelsJsonPath);
registry.registerProvider("anthropic", {
oauth: {
name: "Custom Anthropic OAuth",
login: async () => ({
access: "custom-access-token",
refresh: "custom-refresh-token",
expires: Date.now() + 60_000,
}),
refreshToken: async (credentials) => credentials,
getApiKey: (credentials) => credentials.access,
},
});
expect(getOAuthProvider("anthropic")?.name).toBe("Custom Anthropic OAuth");
registry.unregisterProvider("anthropic");
expect(getOAuthProvider("anthropic")?.name).not.toBe("Custom Anthropic OAuth");
});
test("unregisterProvider removes custom streamSimple override and restores built-in API stream handler", () => {
const registry = new ModelRegistry(authStorage, modelsJsonPath);
registry.registerProvider("stream-override-provider", {
api: "openai-completions",
streamSimple: () => {
throw new Error("custom streamSimple override");
},
});
let threwCustomOverride = false;
try {
getApiProvider("openai-completions")?.streamSimple(openAiModel, emptyContext);
} catch (error) {
threwCustomOverride = error instanceof Error && error.message === "custom streamSimple override";
}
expect(threwCustomOverride).toBe(true);
registry.unregisterProvider("stream-override-provider");
let threwCustomOverrideAfterUnregister = false;
try {
getApiProvider("openai-completions")?.streamSimple(openAiModel, emptyContext);
} catch (error) {
threwCustomOverrideAfterUnregister =
error instanceof Error && error.message === "custom streamSimple override";
}
expect(threwCustomOverrideAfterUnregister).toBe(false);
});
});
describe("API key resolution", () => {
/** Create provider config with custom apiKey */
function providerWithApiKey(apiKey: string) {