perf(tui): optimize image line detection and box cache (#1084)

- Add isImageLine() to terminal-image.ts with single startsWith check based on detected terminal protocol
- Replace dual includes() checks in tui.ts with imported isImageLine()
- Add image line handling to markdown.ts to skip wrapping and margins for image escapes
- Consolidate Box cache into RenderCache type with childLines/width/bgSample/lines fields
- Use in-place mutation in applyLineResets() to avoid array allocation
This commit is contained in:
Can Bölük 2026-01-30 02:25:19 +01:00 committed by GitHub
parent e045a9f142
commit 4058346a64
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 73 additions and 30 deletions

View file

@ -1,6 +1,13 @@
import type { Component } from "../tui.js";
import { applyBackgroundToLine, visibleWidth } from "../utils.js";
type RenderCache = {
childLines: string[];
width: number;
bgSample: string | undefined;
lines: string[];
};
/**
* Box component - a container that applies padding and background to all children
*/
@ -11,10 +18,7 @@ export class Box implements Component {
private bgFn?: (text: string) => string;
// Cache for rendered output
private cachedWidth?: number;
private cachedChildLines?: string;
private cachedBgSample?: string;
private cachedLines?: string[];
private cache?: RenderCache;
constructor(paddingX = 1, paddingY = 1, bgFn?: (text: string) => string) {
this.paddingX = paddingX;
@ -46,10 +50,18 @@ export class Box implements Component {
}
private invalidateCache(): void {
this.cachedWidth = undefined;
this.cachedChildLines = undefined;
this.cachedBgSample = undefined;
this.cachedLines = undefined;
this.cache = undefined;
}
private matchCache(width: number, childLines: string[], bgSample: string | undefined): boolean {
const cache = this.cache;
return (
!!cache &&
cache.width === width &&
cache.bgSample === bgSample &&
cache.childLines.length === childLines.length &&
cache.childLines.every((line, i) => line === childLines[i])
);
}
invalidate(): void {
@ -84,14 +96,8 @@ export class Box implements Component {
const bgSample = this.bgFn ? this.bgFn("test") : undefined;
// Check cache validity
const childLinesKey = childLines.join("\n");
if (
this.cachedLines &&
this.cachedWidth === width &&
this.cachedChildLines === childLinesKey &&
this.cachedBgSample === bgSample
) {
return this.cachedLines;
if (this.matchCache(width, childLines, bgSample)) {
return this.cache!.lines;
}
// Apply background and padding
@ -113,10 +119,7 @@ export class Box implements Component {
}
// Update cache
this.cachedWidth = width;
this.cachedChildLines = childLinesKey;
this.cachedBgSample = bgSample;
this.cachedLines = result;
this.cache = { childLines, width, bgSample, lines: result };
return result;
}

View file

@ -1,4 +1,5 @@
import { marked, type Token } from "marked";
import { isImageLine } from "../terminal-image.js";
import type { Component } from "../tui.js";
import { applyBackgroundToLine, visibleWidth, wrapTextWithAnsi } from "../utils.js";
@ -121,7 +122,11 @@ export class Markdown implements Component {
// Wrap lines (NO padding, NO background yet)
const wrappedLines: string[] = [];
for (const line of renderedLines) {
wrappedLines.push(...wrapTextWithAnsi(line, contentWidth));
if (isImageLine(line)) {
wrappedLines.push(line);
} else {
wrappedLines.push(...wrapTextWithAnsi(line, contentWidth));
}
}
// Add margins and background to each wrapped line
@ -131,6 +136,11 @@ export class Markdown implements Component {
const contentLines: string[] = [];
for (const line of wrappedLines) {
if (isImageLine(line)) {
contentLines.push(line);
continue;
}
const lineWithMargins = leftMargin + line + rightMargin;
if (bgFn) {