fix(coding-agent): bind extension UI context on startup

This commit is contained in:
Mario Zechner 2026-01-26 23:00:48 +01:00
parent f86e3c3103
commit 5dbeadae05
4 changed files with 60 additions and 66 deletions

View file

@ -6,6 +6,7 @@
- Git extension updates now handle force-pushed remotes gracefully instead of failing ([#961](https://github.com/badlogic/pi-mono/pull/961) by [@aliou](https://github.com/aliou)) - Git extension updates now handle force-pushed remotes gracefully instead of failing ([#961](https://github.com/badlogic/pi-mono/pull/961) by [@aliou](https://github.com/aliou))
- Extension `ctx.newSession({ setup })` now properly syncs agent state and renders messages after setup callback runs ([#968](https://github.com/badlogic/pi-mono/issues/968)) - Extension `ctx.newSession({ setup })` now properly syncs agent state and renders messages after setup callback runs ([#968](https://github.com/badlogic/pi-mono/issues/968))
- Fixed extension UI bindings not initializing when starting with no extensions, which broke UI methods after `/reload`
## [0.50.0] - 2026-01-26 ## [0.50.0] - 2026-01-26

View file

@ -976,13 +976,6 @@ export class InteractiveMode {
* Initialize the extension system with TUI-based UI context. * Initialize the extension system with TUI-based UI context.
*/ */
private async initExtensions(): Promise<void> { private async initExtensions(): Promise<void> {
const extensionRunner = this.session.extensionRunner;
if (!extensionRunner) {
this.showLoadedResources({ extensionPaths: [], force: false });
return;
}
// Create extension UI context
const uiContext = this.createExtensionUIContext(); const uiContext = this.createExtensionUIContext();
await this.session.bindExtensions({ await this.session.bindExtensions({
uiContext, uiContext,
@ -1057,6 +1050,12 @@ export class InteractiveMode {
}, },
}); });
const extensionRunner = this.session.extensionRunner;
if (!extensionRunner) {
this.showLoadedResources({ extensionPaths: [], force: false });
return;
}
this.setupExtensionShortcuts(extensionRunner); this.setupExtensionShortcuts(extensionRunner);
this.showLoadedResources({ extensionPaths: extensionRunner.getExtensionPaths(), force: false }); this.showLoadedResources({ extensionPaths: extensionRunner.getExtensionPaths(), force: false });
} }

View file

@ -36,8 +36,6 @@ export async function runPrintMode(session: AgentSession, options: PrintModeOpti
} }
} }
// Set up extensions for print mode (no UI) // Set up extensions for print mode (no UI)
const extensionRunner = session.extensionRunner;
if (extensionRunner) {
await session.bindExtensions({ await session.bindExtensions({
commandContextActions: { commandContextActions: {
waitForIdle: () => session.agent.waitForIdle(), waitForIdle: () => session.agent.waitForIdle(),
@ -66,7 +64,6 @@ export async function runPrintMode(session: AgentSession, options: PrintModeOpti
console.error(`Extension error (${err.extensionPath}): ${err.error}`); console.error(`Extension error (${err.extensionPath}): ${err.error}`);
}, },
}); });
}
// Always subscribe to enable session persistence via _handleAgentEvent // Always subscribe to enable session persistence via _handleAgentEvent
session.subscribe((event) => { session.subscribe((event) => {

View file

@ -254,8 +254,6 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
}); });
// Set up extensions with RPC-based UI context // Set up extensions with RPC-based UI context
const extensionRunner = session.extensionRunner;
if (extensionRunner) {
await session.bindExtensions({ await session.bindExtensions({
uiContext: createExtensionUIContext(), uiContext: createExtensionUIContext(),
commandContextActions: { commandContextActions: {
@ -286,7 +284,6 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
output({ type: "extension_error", extensionPath: err.extensionPath, event: err.event, error: err.error }); output({ type: "extension_error", extensionPath: err.extensionPath, event: err.event, error: err.error });
}, },
}); });
}
// Output all agent events as JSON // Output all agent events as JSON
session.subscribe((event) => { session.subscribe((event) => {