getcompanion-ai/co-mono
1
0
Fork 0
mirror of https://github.com/getcompanion-ai/co-mono.git synced 2026-04-16 20:01:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix race condition by making window.complete() async and awaiting it

Browse source 
- window.complete() was fire-and-forget, causing execution-complete to arrive before console messages
- This caused sandbox to unregister before console message responses arrived
- Made complete() async and await sendRuntimeMessage()
- SandboxedIframe wrapper now awaits window.complete()
- Ensures all messages are processed before cleanup/unregister
- Fixes 30-second timeout on javascript_repl
This commit is contained in:
Mario Zechner 2025-10-09 20:31:48 +02:00
parent bb138307b1
commit 5dcb5ecc89
2 changed files with 10 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
packages/web-ui/src/components/SandboxedIframe.ts
View file

@ -339,7 +339,7 @@ export class SandboxIframe extends LitElement {
} }
} }
window.complete(); await window.complete();
} catch (error) { } catch (error) {
console.error(error?.stack || error?.message || String(error)); console.error(error?.stack || error?.message || String(error));
@ -352,7 +352,7 @@ export class SandboxIframe extends LitElement {
} }
} }
window.complete({ await window.complete({
message: error?.message || String(error), message: error?.message || String(error),
stack: error?.stack || new Error().stack stack: error?.stack || new Error().stack
}); });

20
packages/web-ui/src/components/sandbox/ConsoleRuntimeProvider.ts
View file

@ -120,7 +120,7 @@ export class ConsoleRuntimeProvider implements SandboxRuntimeProvider {
// Expose complete() method for user code to call // Expose complete() method for user code to call
let completionSent = false; let completionSent = false;
(window as any).complete = (error?: { message: string; stack: string }) => { (window as any).complete = async (error?: { message: string; stack: string }) => {
if (completionSent) return; if (completionSent) return;
completionSent = true; completionSent = true;
@ -128,18 +128,14 @@ export class ConsoleRuntimeProvider implements SandboxRuntimeProvider {
if ((window as any).sendRuntimeMessage) { if ((window as any).sendRuntimeMessage) {
if (finalError) { if (finalError) {
(window as any) await (window as any).sendRuntimeMessage({
.sendRuntimeMessage({ type: "execution-error",
type: "execution-error", error: finalError,
error: finalError, });
})
.catch(() => {});
} else { } else {
(window as any) await (window as any).sendRuntimeMessage({
.sendRuntimeMessage({ type: "execution-complete",
type: "execution-complete", });
})
.catch(() => {});
} }
} }
}; };