feat(coding-agent): make ctx.shutdown() available for extensions (#542)

This commit is contained in:
Kao Félix 2026-01-08 03:30:48 +01:00 committed by GitHub
parent 7f3fa417c4
commit 6845c4b85e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 164 additions and 2 deletions

View file

@ -174,6 +174,9 @@ export class InteractiveMode {
// Messages queued while compaction is running
private compactionQueuedMessages: CompactionQueuedMessage[] = [];
// Shutdown state
private shutdownRequested = false;
// Extension UI state
private extensionSelector: ExtensionSelectorComponent | undefined = undefined;
private extensionInput: ExtensionInputComponent | undefined = undefined;
@ -628,6 +631,9 @@ export class InteractiveMode {
isIdle: () => !this.session.isStreaming,
abort: () => this.session.abort(),
hasPendingMessages: () => this.session.pendingMessageCount > 0,
shutdown: () => {
this.shutdownRequested = true;
},
},
// ExtensionCommandContextActions - for ctx.* in command handlers
{
@ -760,6 +766,9 @@ export class InteractiveMode {
isIdle: () => !this.session.isStreaming,
abort: () => this.session.abort(),
hasPendingMessages: () => this.session.pendingMessageCount > 0,
shutdown: () => {
this.shutdownRequested = true;
},
});
// Set up the extension shortcut handler on the default editor
@ -1617,6 +1626,9 @@ export class InteractiveMode {
this.streamingMessage = undefined;
}
this.pendingTools.clear();
await this.checkShutdownRequested();
this.ui.requestRender();
break;
@ -1930,7 +1942,12 @@ export class InteractiveMode {
* Gracefully shutdown the agent.
* Emits shutdown event to extensions, then exits.
*/
private isShuttingDown = false;
private async shutdown(): Promise<void> {
if (this.isShuttingDown) return;
this.isShuttingDown = true;
// Emit shutdown event to extensions
const extensionRunner = this.session.extensionRunner;
if (extensionRunner?.hasHandlers("session_shutdown")) {
@ -1943,6 +1960,14 @@ export class InteractiveMode {
process.exit(0);
}
/**
* Check if shutdown was requested and perform shutdown if so.
*/
private async checkShutdownRequested(): Promise<void> {
if (!this.shutdownRequested) return;
await this.shutdown();
}
private handleCtrlZ(): void {
// Set up handler to restore TUI when resumed
process.once("SIGCONT", () => {

View file

@ -66,6 +66,7 @@ export async function runPrintMode(session: AgentSession, options: PrintModeOpti
isIdle: () => !session.isStreaming,
abort: () => session.abort(),
hasPendingMessages: () => session.pendingMessageCount > 0,
shutdown: () => {},
},
// ExtensionCommandContextActions - commands invokable via prompt("/command")
{

View file

@ -63,6 +63,9 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
{ resolve: (value: any) => void; reject: (error: Error) => void }
>();
// Shutdown request flag
let shutdownRequested = false;
/** Helper for dialog methods with signal/timeout support */
function createDialogPromise<T>(
opts: ExtensionUIDialogOptions | undefined,
@ -265,6 +268,9 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
isIdle: () => !session.isStreaming,
abort: () => session.abort(),
hasPendingMessages: () => session.pendingMessageCount > 0,
shutdown: () => {
shutdownRequested = true;
},
},
// ExtensionCommandContextActions - commands invokable via prompt("/command")
{
@ -515,6 +521,22 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
}
};
/**
* Check if shutdown was requested and perform shutdown if so.
* Called after handling each command when waiting for the next command.
*/
async function checkShutdownRequested(): Promise<void> {
if (!shutdownRequested) return;
if (extensionRunner?.hasHandlers("session_shutdown")) {
await extensionRunner.emit({ type: "session_shutdown" });
}
// Close readline interface to stop waiting for input
rl.close();
process.exit(0);
}
// Listen for JSON input
const rl = readline.createInterface({
input: process.stdin,
@ -541,6 +563,9 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
const command = parsed as RpcCommand;
const response = await handleCommand(command);
output(response);
// Check for deferred shutdown request (idle between commands)
await checkShutdownRequested();
} catch (e: any) {
output(error(undefined, "parse", `Failed to parse command: ${e.message}`));
}