getcompanion-ai/co-mono
1
0
Fork 0
mirror of https://github.com/getcompanion-ai/co-mono.git synced 2026-04-18 22:04:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(coding-agent): prevent global AGENTS.md from being loaded twice (#239)

Browse source 
When cwd is `~/.pi/agent/` or a subdirectory, the global AGENTS.md file
was included twice in the system prompt.

`loadProjectContextFiles()` loads context files in two steps:
1. Explicitly loads from `getAgentDir()` (`~/.pi/agent/`)
2. Walks from cwd up to root, collecting all AGENTS.md/CLAUDE.md files

There was no deduplication. When cwd is at or below `~/.pi/agent/`, the
ancestor walk includes that directory again.

Fix: track seen paths with a Set and skip duplicates.
This commit is contained in:
Aliou Diallo 2025-12-19 15:24:49 +01:00 • committed by GitHub
parent a54c70bbed
commit a9a1a62b14
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
packages/coding-agent/src/core/system-prompt.ts
View file

@ -65,12 +65,14 @@ function loadContextFileFromDir(dir: string): { path: string; content: string }
*/ */
export function loadProjectContextFiles(): Array<{ path: string; content: string }> { export function loadProjectContextFiles(): Array<{ path: string; content: string }> {
const contextFiles: Array<{ path: string; content: string }> = []; const contextFiles: Array<{ path: string; content: string }> = [];
const seenPaths = new Set<string>();
// 1. Load global context from ~/{CONFIG_DIR_NAME}/agent/ // 1. Load global context from ~/{CONFIG_DIR_NAME}/agent/
const globalContextDir = getAgentDir(); const globalContextDir = getAgentDir();
const globalContext = loadContextFileFromDir(globalContextDir); const globalContext = loadContextFileFromDir(globalContextDir);
if (globalContext) { if (globalContext) {
contextFiles.push(globalContext); contextFiles.push(globalContext);
seenPaths.add(globalContext.path);
} }
// 2. Walk up from cwd to root, collecting all context files // 2. Walk up from cwd to root, collecting all context files
@ -82,9 +84,10 @@ export function loadProjectContextFiles(): Array<{ path: string; content: string
while (true) { while (true) {
const contextFile = loadContextFileFromDir(currentDir); const contextFile = loadContextFileFromDir(currentDir);
if (contextFile) { if (contextFile && !seenPaths.has(contextFile.path)) {
// Add to beginning so we get top-most parent first // Add to beginning so we get top-most parent first
ancestorContextFiles.unshift(contextFile); ancestorContextFiles.unshift(contextFile);
seenPaths.add(contextFile.path);
} }
// Stop if we've reached root // Stop if we've reached root