getcompanion-ai/co-mono
1
0
Fork 0
mirror of https://github.com/getcompanion-ai/co-mono.git synced 2026-04-15 23:01:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(coding-agent): use built-in renderers for tool overrides without custom renderers

Browse source 
When overriding a built-in tool (read, bash, edit, write, grep, find, ls)
without providing renderCall/renderResult, the built-in renderer is now
used automatically. This allows wrapping built-in tools for logging or
access control without reimplementing the UI (syntax highlighting, diffs, etc.).
This commit is contained in:
Mario Zechner 2026-01-08 13:25:41 +01:00
parent 66cbcee347
commit bbf0d92e8c
2 changed files with 30 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

40
packages/coding-agent/src/modes/interactive/components/tool-execution.ts
View file

@ -13,6 +13,7 @@ import {
import stripAnsi from "strip-ansi";
import type { ToolDefinition } from "../../../core/extensions/types.js";
import { computeEditDiff, type EditDiffError, type EditDiffResult } from "../../../core/tools/edit-diff.js";
import { allTools } from "../../../core/tools/index.js";
import { DEFAULT_MAX_BYTES, DEFAULT_MAX_LINES, formatSize } from "../../../core/tools/truncate.js";
import { convertToPng } from "../../../utils/image-convert.js";
import { sanitizeBinaryOutput } from "../../../utils/shell.js";
@ -94,7 +95,9 @@ export class ToolExecutionComponent extends Container {
this.contentBox = new Box(1, 1, (text: string) => theme.bg("toolPendingBg", text));
this.contentText = new Text("", 1, 1, (text: string) => theme.bg("toolPendingBg", text));
if (toolDefinition || toolName === "bash") {
// Use contentBox for bash (visual truncation) or custom tools with custom renderers
// Use contentText for built-in tools (including overrides without custom renderers)
if (toolName === "bash" || (toolDefinition && !this.shouldUseBuiltInRenderer())) {
this.addChild(this.contentBox);
} else {
this.addChild(this.contentText);
@ -103,6 +106,17 @@ export class ToolExecutionComponent extends Container {
this.updateDisplay();
}
/**
* Check if we should use built-in rendering for this tool.
* Returns true if the tool name is a built-in AND either there's no toolDefinition
* or the toolDefinition doesn't provide custom renderers.
*/
private shouldUseBuiltInRenderer(): boolean {
const isBuiltInName = this.toolName in allTools;
const hasCustomRenderers = this.toolDefinition?.renderCall || this.toolDefinition?.renderResult;
return isBuiltInName && !hasCustomRenderers;
}
updateArgs(args: any): void {
this.args = args;
this.updateDisplay();
@ -213,8 +227,19 @@ export class ToolExecutionComponent extends Container {
? (text: string) => theme.bg("toolErrorBg", text)
: (text: string) => theme.bg("toolSuccessBg", text);
// Check for custom tool rendering
if (this.toolDefinition) {
// Use built-in rendering for built-in tools (or overrides without custom renderers)
if (this.shouldUseBuiltInRenderer()) {
if (this.toolName === "bash") {
// Bash uses Box with visual line truncation
this.contentBox.setBgFn(bgFn);
this.contentBox.clear();
this.renderBashContent();
} else {
// Other built-in tools: use Text directly with caching
this.contentText.setCustomBgFn(bgFn);
this.contentText.setText(this.formatToolExecution());
}
} else if (this.toolDefinition) {
// Custom tools use Box for flexible component rendering
this.contentBox.setBgFn(bgFn);
this.contentBox.clear();
@ -260,15 +285,6 @@ export class ToolExecutionComponent extends Container {
this.contentBox.addChild(new Text(theme.fg("toolOutput", output), 0, 0));
}
}
} else if (this.toolName === "bash") {
// Bash uses Box with visual line truncation
this.contentBox.setBgFn(bgFn);
this.contentBox.clear();
this.renderBashContent();
} else {
// Other built-in tools: use Text directly with caching
this.contentText.setCustomBgFn(bgFn);
this.contentText.setText(this.formatToolExecution());
}
// Handle images (same for both custom and built-in)