getcompanion-ai/co-mono
1
0
Fork 0
mirror of https://github.com/getcompanion-ai/co-mono.git synced 2026-04-15 19:05:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Do not create empty .pi folder unconditionally (#1588)

Browse source
This commit is contained in:
Duncan Ogilvie 2026-02-23 00:59:10 +01:00 • committed by GitHub
parent 6137de9ce7
commit f1a2092bcf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 61 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

44
packages/coding-agent/test/settings-manager.test.ts
View file

@ -212,6 +212,50 @@ describe("SettingsManager", () => {
});
});
describe("project settings directory creation", () => {
it("should not create .pi folder when only reading project settings", () => {
// Create agent dir with global settings, but NO .pi folder in project
const settingsPath = join(agentDir, "settings.json");
writeFileSync(settingsPath, JSON.stringify({ theme: "dark" }));
// Delete the .pi folder that beforeEach created
rmSync(join(projectDir, ".pi"), { recursive: true });
// Create SettingsManager (reads both global and project settings)
const manager = SettingsManager.create(projectDir, agentDir);
// .pi folder should NOT have been created just from reading
expect(existsSync(join(projectDir, ".pi"))).toBe(false);
// Settings should still be loaded from global
expect(manager.getTheme()).toBe("dark");
});
it("should create .pi folder when writing project settings", async () => {
// Create agent dir with global settings, but NO .pi folder in project
const settingsPath = join(agentDir, "settings.json");
writeFileSync(settingsPath, JSON.stringify({ theme: "dark" }));
// Delete the .pi folder that beforeEach created
rmSync(join(projectDir, ".pi"), { recursive: true });
const manager = SettingsManager.create(projectDir, agentDir);
// .pi folder should NOT exist yet
expect(existsSync(join(projectDir, ".pi"))).toBe(false);
// Write a project-specific setting
manager.setProjectPackages([{ source: "npm:test-pkg" }]);
await manager.flush();
// Now .pi folder should exist
expect(existsSync(join(projectDir, ".pi"))).toBe(true);
// And settings file should be created
expect(existsSync(join(projectDir, ".pi", "settings.json"))).toBe(true);
});
});
describe("shellCommandPrefix", () => {
it("should load shellCommandPrefix from settings", () => {
const settingsPath = join(agentDir, "settings.json");