feat(contracts): add published ports, snapshot request, and storage report types

internal/firecracker/api.go

@@ -231,7 +231,9 @@ func (c *apiClient) do(ctx context.Context, method string, endpoint string, inpu
 	if err != nil {
 		return fmt.Errorf("do %s %s via %q: %w", method, endpoint, c.socketPath, err)
 	}
-	defer response.Body.Close()
+	defer func() {
+		_ = response.Body.Close()
+	}()
 
 	if response.StatusCode != wantStatus {
 		return decodeFirecrackerError(method, endpoint, response)

internal/firecracker/launch.go

@@ -161,7 +161,6 @@ func waitForSocket(ctx context.Context, client *apiClient, socketPath string) er
 				lastPingErr = err
 				continue
 			}
-			lastPingErr = nil
 			return nil
 		}
 	}
@@ -231,13 +230,6 @@ func waitForPIDFile(ctx context.Context, pidFilePath string) (int, error) {
 	}
 }
 
-func hostVSockPath(paths machinePaths, spec MachineSpec) string {
-	if spec.Vsock == nil {
-		return ""
-	}
-	return filepath.Join(paths.ChrootRootDir, defaultFirecrackerSocketDir, filepath.Base(strings.TrimSpace(spec.Vsock.Path)))
-}
-
 func jailedVSockPath(spec MachineSpec) string {
 	if spec.Vsock == nil {
 		return ""

internal/firecracker/paths.go

@@ -67,18 +67,3 @@ func buildMachinePaths(rootDir string, id MachineID, firecrackerBinaryPath strin
 func procSocketPath(pid int) string {
 	return filepath.Join("/proc", strconv.Itoa(pid), "root", defaultFirecrackerSocketDir, defaultFirecrackerSocketName)
 }
-
-type snapshotPaths struct {
-	BaseDir       string
-	MemFilePath   string
-	StateFilePath string
-}
-
-func buildSnapshotPaths(rootDir string, id string) snapshotPaths {
-	baseDir := filepath.Join(rootDir, "snapshots", id)
-	return snapshotPaths{
-		BaseDir:       baseDir,
-		MemFilePath:   filepath.Join(baseDir, "memory.bin"),
-		StateFilePath: filepath.Join(baseDir, "vmstate.bin"),
-	}
-}