harivansh-afk/sandbox-agent
1
0
Fork 0
mirror of https://github.com/harivansh-afk/sandbox-agent.git synced 2026-04-16 17:01:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: prevent permission reply from silently escalating "once" to "always"

Browse source 
Remove allow_always from the fallback chain when the user replies "once",
aligning with the ACP spec which says "map by option kind first" with no
fallback for allow_once. Also fix Inspector to use rawSend, revert
hydration guard to accept empty configOptions, and handle respondPermission
errors by rejecting the pending promise.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Nathan Flurry 2026-03-10 21:52:31 -07:00
parent e8ffd78ac0
commit 6f66f92e72
4 changed files with 16 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

13
sdks/typescript/src/client.ts
View file

@ -1262,7 +1262,7 @@ export class SandboxAgent {
}
private async hydrateSessionConfigOptions(sessionId: string, snapshot: SessionRecord): Promise<SessionRecord> {
if (snapshot.configOptions !== undefined && snapshot.configOptions.length > 0) {
if (snapshot.configOptions !== undefined) {
return snapshot;
}
@ -1440,7 +1440,14 @@ export class SandboxAgent {
throw new Error(`permission '${permissionId}' not found`);
}
const response = permissionReplyToResponse(permissionId, pending.request, reply);
let response: RequestPermissionResponse;
try {
response = permissionReplyToResponse(permissionId, pending.request, reply);
} catch (error) {
pending.reject(error instanceof Error ? error : new Error(String(error)));
this.pendingPermissionRequests.delete(permissionId);
throw error;
}
this.resolvePendingPermission(permissionId, response);
}
@ -2704,7 +2711,7 @@ function permissionReplyToResponse(
): RequestPermissionResponse {
const preferredKinds: PermissionOptionKind[] =
reply === "once"
? ["allow_once", "allow_always"]
? ["allow_once"]
: reply === "always"
? ["allow_always", "allow_once"]
: ["reject_once", "reject_always"];