harivansh-afk/sandbox-agent
1
0
Fork 0
mirror of https://github.com/harivansh-afk/sandbox-agent.git synced 2026-04-15 10:05:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix Modal provider: pre-install agents in image, fire-and-forget exec for server

Browse source 
- Pre-install agents in Dockerfile commands so they are cached across creates
- Use fire-and-forget exec (no wait) to keep server alive in Modal sandbox
- Add memoryMiB option (default 2GB) to avoid OOM during agent install

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Nathan Flurry 2026-03-15 15:51:51 -07:00
parent 20202c45ee
commit f5d64ca0fd
1 changed files with 13 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

31
sdks/typescript/src/providers/modal.ts
View file

@ -1,14 +1,16 @@
import { ModalClient } from "modal";
import type { SandboxProvider } from "./types.ts";
import { DEFAULT_AGENTS, SANDBOX_AGENT_INSTALL_SCRIPT, buildServerStartCommand } from "./shared.ts";
import { DEFAULT_AGENTS, SANDBOX_AGENT_INSTALL_SCRIPT } from "./shared.ts";
const DEFAULT_AGENT_PORT = 3000;
const DEFAULT_APP_NAME = "sandbox-agent";
const DEFAULT_MEMORY_MIB = 2048;
export interface ModalProviderOptions {
create?: {
secrets?: Record<string, string>;
appName?: string;
memoryMiB?: number;
};
agentPort?: number;
}
@ -16,6 +18,7 @@ export interface ModalProviderOptions {
export function modal(options: ModalProviderOptions = {}): SandboxProvider {
const agentPort = options.agentPort ?? DEFAULT_AGENT_PORT;
const appName = options.create?.appName ?? DEFAULT_APP_NAME;
const memoryMiB = options.create?.memoryMiB ?? DEFAULT_MEMORY_MIB;
const client = new ModalClient();
return {
@ -23,11 +26,15 @@ export function modal(options: ModalProviderOptions = {}): SandboxProvider {
async create(): Promise<string> {
const app = await client.apps.fromName(appName, { createIfMissing: true });
// Pre-install sandbox-agent and agents in the image so they are cached
// across sandbox creates and don't need to be installed at runtime.
const installAgentCmds = DEFAULT_AGENTS.map((agent) => `RUN sandbox-agent install-agent ${agent}`);
const image = client.images
.fromRegistry("node:22-slim")
.dockerfileCommands([
"RUN apt-get update && apt-get install -y curl ca-certificates && rm -rf /var/lib/apt/lists/*",
`RUN curl -fsSL ${SANDBOX_AGENT_INSTALL_SCRIPT} | sh`,
...installAgentCmds,
]);
const envVars = options.create?.secrets ?? {};
@ -36,25 +43,13 @@ export function modal(options: ModalProviderOptions = {}): SandboxProvider {
const sb = await client.sandboxes.create(app, image, {
encryptedPorts: [agentPort],
secrets,
memoryMiB,
});
const exec = async (cmd: string) => {
const p = await sb.exec(["bash", "-c", cmd], {
stdout: "pipe",
stderr: "pipe",
});
const exitCode = await p.wait();
if (exitCode !== 0) {
const stderr = await p.stderr.readText();
throw new Error(`modal command failed (exit ${exitCode}): ${cmd}\n${stderr}`);
}
};
for (const agent of DEFAULT_AGENTS) {
await exec(`sandbox-agent install-agent ${agent}`);
}
await sb.exec(["bash", "-c", buildServerStartCommand(agentPort)]);
// Start the server as a long-running exec process. We intentionally
// do NOT await p.wait() — the process stays alive for the sandbox
// lifetime and keeps the port open for the tunnel.
sb.exec(["sandbox-agent", "server", "--no-token", "--host", "0.0.0.0", "--port", String(agentPort)]);
return sb.sandboxId;
},