harivansh-afk/sandbox-agent
1
0
Fork 0
mirror of https://github.com/harivansh-afk/sandbox-agent.git synced 2026-04-15 13:03:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

docs: update PRD and progress for US-035

Browse source 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Nathan Flurry 2026-03-17 15:28:17 -07:00
parent 66ca6529b1
commit fe0990452c
2 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
scripts/ralph/prd.json
View file

@ -572,7 +572,7 @@
"Typecheck passes"
],
"priority": 35,
"passes": false,
"passes": true,
"notes": "BrowserProblem::start_failed (500 status, browser/start-failed code) is used as a catch-all for filesystem errors in browser_context.rs which makes error codes meaningless for API consumers."
},
{

11
scripts/ralph/progress.txt
View file

@ -628,3 +628,14 @@ Started: Tue Mar 17 04:32:06 AM PDT 2026
- Mutual exclusivity checks should be placed BEFORE acquiring the state lock, consistent with BrowserRuntime's pattern
- `OnceLock` implements Debug and Clone (when T does), so it works with `#[derive(Debug, Clone)]` on the parent struct
---
## 2026-03-17 - US-035
- Added `internal_error` variant to `BrowserProblem` (500 status, `browser/internal-error` code) for filesystem/serialization errors
- Replaced all 5 `BrowserProblem::start_failed` usages in `browser_context.rs` with `BrowserProblem::internal_error`
- Fixed misleading comment in `browser_runtime.rs` console event handler: now actually normalizes CDP "warning" level to "warn"
- Files changed: browser_errors.rs, browser_context.rs, browser_runtime.rs
- **Learnings for future iterations:**
- `BrowserProblem::start_failed` should only be used for actual browser startup failures, not generic server-side errors
- CDP console event `type` field uses "warning" (not "warn") — always normalize to "warn" for consistency with standard log levels
- When adding new error variants, check existing tests in the module's `#[cfg(test)] mod tests` to ensure they still pass
---