harivansh-afk/sandbox-agent
1
0
Fork 0
mirror of https://github.com/harivansh-afk/sandbox-agent.git synced 2026-04-15 08:03:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
sandbox-agent/foundry/research/specs/async-action-fixes
History
Nathan Flurry ae191d1ae1
Refactor Foundry GitHub state and sandbox runtime (#247) 
* Move Foundry HTTP APIs out of /api/rivet

* Move Foundry HTTP APIs onto /v1

* Fix Foundry Rivet base path and frontend endpoint fallback

* Configure Foundry Rivet runner pool for /v1

* Remove Foundry Rivet runner override

* Serve Foundry Rivet routes directly from Bun

* Log Foundry RivetKit deployment friction

* Add actor display metadata

* Tighten actor schema constraints

* Reset actor persistence baseline

* Remove temporary actor key version prefix

Railway has no persistent volumes so stale actors are wiped on
each deploy. The v2 key rotation is no longer needed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Cache app workspace actor handle across requests

Every request was calling getOrCreate on the Rivet engine API
to resolve the workspace actor, even though it's always the same
actor. Cache the handle and invalidate on error so retries
re-resolve. This eliminates redundant cross-region round-trips
to api.rivet.dev on every request.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add temporary debug logging to GitHub OAuth exchange

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Make squashed baseline migrations idempotent

Use CREATE TABLE IF NOT EXISTS and CREATE UNIQUE INDEX IF NOT
EXISTS so the squashed baseline can run against actors that
already have tables from the pre-squash migration sequence.
This fixes the "table already exists" error when org workspace
actors wake up with stale migration journals.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Revert "Make squashed baseline migrations idempotent"

This reverts commit 356c146035.

* Fix GitHub OAuth callback by removing retry wrapper

OAuth authorization codes are single-use. The appWorkspaceAction wrapper
retries failed calls up to 20 times, but if the code exchange succeeds
and a later step fails, every retry sends the already-consumed code,
producing "bad_verification_code" from GitHub.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add runner versioning to RivetKit registry

Uses Date.now() so each process start gets a unique version.
This ensures Rivet Cloud migrates actors to the new runner on
deploy instead of routing requests to stale runners.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add backend request and workspace logging

* Log callback request headers

* Make GitHub OAuth callback idempotent against duplicate requests

Clear oauthState before exchangeCode so duplicate callback requests
fail the state check instead of hitting GitHub with a consumed code.
Marked as HACK — root cause of duplicate HTTP requests is unknown.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add temporary header dump on GitHub OAuth callback

Log all request headers on the callback endpoint to diagnose
the source of duplicate requests (Railway proxy, Cloudflare, browser).
Remove once root cause is identified.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Defer slow GitHub org sync to workflow queue for fast OAuth callback

Split syncGithubSessionFromToken into a fast path (initGithubSession:
exchange code, get viewer, store token+identity) and a slow path
(syncGithubOrganizations: list orgs/installations, sync workspaces).

completeAppGithubAuth now returns the 302 redirect in ~2s instead of
~18s by enqueuing the org sync to the workspace workflow queue
(fire-and-forget). This eliminates the proxy timeout window that was
causing duplicate callback requests.

bootstrapAppGithubSession (dev-only) still calls the full synchronous
sync since proxy timeouts are not a concern and it needs the session
fully populated before returning.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* foundry: async app repo import on org select

* foundry: parallelize app snapshot org reads

* repo: push all current workspace changes

* foundry: update runner version and snapshot logging

* Refactor Foundry GitHub state and sandbox runtime

Refactors Foundry around organization/repository ownership and adds an organization-scoped GitHub state actor plus a user-scoped GitHub auth actor, removing the old project PR/branch sync actors and repo PR cache.

Updates sandbox provisioning to rely on sandbox-agent for in-sandbox work, hardens Daytona startup and image-build behavior, and surfaces runtime and task-startup errors more clearly in the UI.

Extends workbench and GitHub state handling to track merged PR state, adds runtime-issue tracking, refreshes client/test/config wiring, and documents the main live Foundry test flow plus actor coordination rules.

Also updates the remaining Sandbox Agent install-version references in docs/examples to the current pinned minor channel.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 02:45:07 -07:00
..
00-end-to-end-async-realtime-plan.md Refactor Foundry GitHub state and sandbox runtime (#247) 2026-03-13 02:45:07 -07:00
01-task-creation-bootstrap-only.md Refactor Foundry GitHub state and sandbox runtime (#247) 2026-03-13 02:45:07 -07:00
02-repo-overview-from-cached-projection.md Refactor Foundry GitHub state and sandbox runtime (#247) 2026-03-13 02:45:07 -07:00
03-repo-actions-via-background-workflow.md Refactor Foundry GitHub state and sandbox runtime (#247) 2026-03-13 02:45:07 -07:00
04-workbench-session-creation-without-inline-provisioning.md Refactor Foundry GitHub state and sandbox runtime (#247) 2026-03-13 02:45:07 -07:00
05-workbench-snapshot-from-derived-state.md Refactor Foundry GitHub state and sandbox runtime (#247) 2026-03-13 02:45:07 -07:00
06-daytona-provisioning-staged-background-flow.md Refactor Foundry GitHub state and sandbox runtime (#247) 2026-03-13 02:45:07 -07:00
07-auth-identity-simplification.md Refactor Foundry GitHub state and sandbox runtime (#247) 2026-03-13 02:45:07 -07:00
README.md Refactor Foundry GitHub state and sandbox runtime (#247) 2026-03-13 02:45:07 -07:00

README.md

Async Action Fixes Handoff

Purpose

This folder contains implementation briefs for removing long-running synchronous waits from Foundry request and action paths.

Start with 00-end-to-end-async-realtime-plan.md. It is the umbrella plan for the broader migration away from monolithic snapshots and polling, and it adds the missing runtime hardening and subscription-lifecycle work that the numbered implementation briefs did not previously cover.

The governing policy now lives in foundry/CLAUDE.md:

  • always await send(...)
  • default to wait: false
  • only use wait: true for short, bounded mutations
  • do not force repo/provider sync in read paths
  • only block until the minimum client-needed resource exists

Shared Context

  • Backend actor entry points live under foundry/packages/backend/src/actors.
  • Provider-backed long-running work lives under foundry/packages/backend/src/providers.
  • The main UI consumers are:
    • foundry/packages/frontend/src/components/workspace-dashboard.tsx
    • foundry/packages/frontend/src/components/mock-layout.tsx
    • foundry/packages/client/src/remote/workbench-client.ts
  • Existing non-blocking examples already exist in app-shell GitHub auth/import flows. Use those as the reference pattern for request returns plus background completion.

Suggested Implementation Order

  1. 00-end-to-end-async-realtime-plan.md
  2. 01-task-creation-bootstrap-only.md
  3. 03-repo-actions-via-background-workflow.md
  4. 06-daytona-provisioning-staged-background-flow.md
  5. App shell realtime subscription work from 00-end-to-end-async-realtime-plan.md
  6. 02-repo-overview-from-cached-projection.md
  7. Workspace summary projection work from 00-end-to-end-async-realtime-plan.md
  8. 04-workbench-session-creation-without-inline-provisioning.md
  9. 05-workbench-snapshot-from-derived-state.md
  10. Task-detail direct subscription work from 00-end-to-end-async-realtime-plan.md
  11. 07-auth-identity-simplification.md

Why This Order

  • Runtime hardening and the first async workflow items remove the highest-risk correctness and timeout issues first.
  • App shell realtime is a smaller migration than the workbench and removes the current polling loop early.
  • Workspace summary and task-detail subscription work are easier once long-running mutations already report durable background state.
  • Auth simplification is important, but it should not block the snapshot/polling/runtime fixes.

Fresh Agent Checklist

Before implementing any item:

  1. Read foundry/CLAUDE.md runtime and actor rules.
  2. Read the specific item doc in this folder.
  3. Confirm the current code paths named in that doc still match the repo.
  4. Preserve actor single-writer ownership.
  5. Prefer workflow status and push updates over synchronous completion.