harivansh-afk/sandbox-agent
1
0
Fork 0
mirror of https://github.com/harivansh-afk/sandbox-agent.git synced 2026-04-17 10:02:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
sandbox-agent/foundry/research/specs/async-action-fixes/03-repo-actions-via-background-workflow.md
Nathan Flurry eacbc602e7 Refactor Foundry GitHub state and sandbox runtime 
Refactors Foundry around organization/repository ownership and adds an organization-scoped GitHub state actor plus a user-scoped GitHub auth actor, removing the old project PR/branch sync actors and repo PR cache.

Updates sandbox provisioning to rely on sandbox-agent for in-sandbox work, hardens Daytona startup and image-build behavior, and surfaces runtime and task-startup errors more clearly in the UI.

Extends workbench and GitHub state handling to track merged PR state, adds runtime-issue tracking, refreshes client/test/config wiring, and documents the main live Foundry test flow plus actor coordination rules.

Also updates the remaining Sandbox Agent install-version references in docs/examples to the current pinned minor channel.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
2026-03-13 02:43:00 -07:00

3.2 KiB
Raw Permalink Blame History

Repo Sync And Stack Actions Should Run In Background Workflows

Read 00-end-to-end-async-realtime-plan.md first for the governing migration order, runtime constraints, and realtime client model this brief assumes.

Problem

Repo stack actions currently run inside a synchronous action and surround the action with forced sync before and after. Branch-backed task creation also forces repo sync inline before it can proceed.

These flows depend on repo/network state and can take minutes. They should not hold an action open.

Current Code Context

  • Workspace repo action entry point: foundry/packages/backend/src/actors/workspace/actions.ts
  • Project repo action implementation: foundry/packages/backend/src/actors/project/actions.ts
  • Branch/task index state lives in the project actor SQLite DB.
  • Current forced sync uses the PR and branch polling actors before and after the action.

Target Contract

  • Repo-affecting actions are accepted quickly and run in the background.
  • The project actor owns a durable action record with progress and final result.
  • Clients observe status via project/task state instead of waiting for a single response.

Proposed Fix

  1. Introduce a project-level workflow/job model for repo actions, for example:
    • sync_repo
    • restack_repo
    • restack_subtree
    • rebase_branch
    • reparent_branch
    • register_existing_branch
  2. Persist a job row with:
    • job id
    • action kind
    • target branch fields
    • status
    • message
    • timestamps
  3. Change runRepoStackAction to:
    • validate cheap local inputs only
    • create a job row
    • enqueue the workflow with wait: false
    • return the job id and accepted status immediately
  4. Move pre/post sync into the background workflow.
  5. For branch-backed task creation:
    • use the cached branch projection if present
    • if branch data is stale or missing, enqueue branch registration/refresh work and surface pending state instead of blocking create

Files Likely To Change

  • foundry/packages/backend/src/actors/workspace/actions.ts
  • foundry/packages/backend/src/actors/project/actions.ts
  • foundry/packages/backend/src/actors/project/db/schema.ts
  • foundry/packages/backend/src/actors/project/db/migrations.ts
  • foundry/packages/frontend/src/components/workspace-dashboard.tsx
  • Any shared types in foundry/packages/shared/src

Client Impact

  • Repo action buttons should show queued/running/completed/error job state.
  • Task creation from an existing branch may produce a task in a pending branch-attach state rather than blocking on repo sync.

Acceptance Criteria

  • No repo stack action waits for full git-spice execution inside the request.
  • No action forces branch sync or PR sync inline.
  • Action result state survives retries and backend restarts because the workflow status is persisted.

Implementation Notes

  • Keep validation cheap in the request path; expensive repo inspection belongs in the workflow.
  • If job rows are added, decide whether they are project-owned only or also mirrored into history events for UI consumption.
  • Fresh-agent check: branch-backed task creation and explicit repo stack actions should use the same background job/status vocabulary where possible.