mirror of https://github.com/harivansh-afk/sandbox-agent.git synced 2026-04-15 08:03:46 +00:00

Refactor Foundry GitHub state and sandbox runtime (#247 )

* Move Foundry HTTP APIs out of /api/rivet

* Move Foundry HTTP APIs onto /v1

* Fix Foundry Rivet base path and frontend endpoint fallback

* Configure Foundry Rivet runner pool for /v1

* Remove Foundry Rivet runner override

* Serve Foundry Rivet routes directly from Bun

* Log Foundry RivetKit deployment friction

* Add actor display metadata

* Tighten actor schema constraints

* Reset actor persistence baseline

* Remove temporary actor key version prefix

Railway has no persistent volumes so stale actors are wiped on
each deploy. The v2 key rotation is no longer needed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Cache app workspace actor handle across requests

Every request was calling getOrCreate on the Rivet engine API
to resolve the workspace actor, even though it's always the same
actor. Cache the handle and invalidate on error so retries
re-resolve. This eliminates redundant cross-region round-trips
to api.rivet.dev on every request.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add temporary debug logging to GitHub OAuth exchange

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Make squashed baseline migrations idempotent

Use CREATE TABLE IF NOT EXISTS and CREATE UNIQUE INDEX IF NOT
EXISTS so the squashed baseline can run against actors that
already have tables from the pre-squash migration sequence.
This fixes the "table already exists" error when org workspace
actors wake up with stale migration journals.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Revert "Make squashed baseline migrations idempotent"

This reverts commit 356c146035.

* Fix GitHub OAuth callback by removing retry wrapper

OAuth authorization codes are single-use. The appWorkspaceAction wrapper
retries failed calls up to 20 times, but if the code exchange succeeds
and a later step fails, every retry sends the already-consumed code,
producing "bad_verification_code" from GitHub.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add runner versioning to RivetKit registry

Uses Date.now() so each process start gets a unique version.
This ensures Rivet Cloud migrates actors to the new runner on
deploy instead of routing requests to stale runners.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add backend request and workspace logging

* Log callback request headers

* Make GitHub OAuth callback idempotent against duplicate requests

Clear oauthState before exchangeCode so duplicate callback requests
fail the state check instead of hitting GitHub with a consumed code.
Marked as HACK — root cause of duplicate HTTP requests is unknown.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add temporary header dump on GitHub OAuth callback

Log all request headers on the callback endpoint to diagnose
the source of duplicate requests (Railway proxy, Cloudflare, browser).
Remove once root cause is identified.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Defer slow GitHub org sync to workflow queue for fast OAuth callback

Split syncGithubSessionFromToken into a fast path (initGithubSession:
exchange code, get viewer, store token+identity) and a slow path
(syncGithubOrganizations: list orgs/installations, sync workspaces).

completeAppGithubAuth now returns the 302 redirect in ~2s instead of
~18s by enqueuing the org sync to the workspace workflow queue
(fire-and-forget). This eliminates the proxy timeout window that was
causing duplicate callback requests.

bootstrapAppGithubSession (dev-only) still calls the full synchronous
sync since proxy timeouts are not a concern and it needs the session
fully populated before returning.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* foundry: async app repo import on org select

* foundry: parallelize app snapshot org reads

* repo: push all current workspace changes

* foundry: update runner version and snapshot logging

* Refactor Foundry GitHub state and sandbox runtime

Refactors Foundry around organization/repository ownership and adds an organization-scoped GitHub state actor plus a user-scoped GitHub auth actor, removing the old project PR/branch sync actors and repo PR cache.

Updates sandbox provisioning to rely on sandbox-agent for in-sandbox work, hardens Daytona startup and image-build behavior, and surfaces runtime and task-startup errors more clearly in the UI.

Extends workbench and GitHub state handling to track merged PR state, adds runtime-issue tracking, refreshes client/test/config wiring, and documents the main live Foundry test flow plus actor coordination rules.

Also updates the remaining Sandbox Agent install-version references in docs/examples to the current pinned minor channel.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

2026-03-13 02:45:07 -07:00

3.1 KiB

Raw Blame History

Repo Overview Should Read Cached State Only

Read 00-end-to-end-async-realtime-plan.md first for the governing migration order, runtime constraints, and realtime client model this brief assumes.

Problem

Repo overview currently forces PR sync and branch sync inline before returning data. That turns a read path into:

repo fetch
branch enumeration
diff/conflict calculations
GitHub PR listing

The frontend polls repo overview repeatedly, so this design multiplies slow work and ties normal browsing to sync latency.

Current Code Context

Workspace overview entry point: foundry/packages/backend/src/actors/workspace/actions.ts
Project overview implementation: foundry/packages/backend/src/actors/project/actions.ts
Branch sync poller: foundry/packages/backend/src/actors/project-branch-sync/index.ts
PR sync poller: foundry/packages/backend/src/actors/project-pr-sync/index.ts
Repo overview client polling: foundry/packages/frontend/src/components/workspace-dashboard.tsx

Target Contract

getRepoOverview returns the latest cached repo projection immediately.
Sync happens on a background cadence or on an explicit async refresh trigger.
Overview responses include freshness metadata so the client can show "refreshing" or "stale" state without blocking.

Proposed Fix

Remove inline forceProjectSync() from getRepoOverview.
Add freshness fields to the project projection, for example:
- branchSyncAt
- prSyncAt
- branchSyncStatus
- prSyncStatus
Let the existing polling actors own cache refresh.
If the client needs a manual refresh, add a non-blocking command such as project.requestOverviewRefresh that:
- enqueues refresh work
- updates sync status to queued or running
- returns immediately
Keep getRepoOverview as a pure read over project SQLite state.

Files Likely To Change

foundry/packages/backend/src/actors/workspace/actions.ts
foundry/packages/backend/src/actors/project/actions.ts
foundry/packages/backend/src/actors/project/db/schema.ts
foundry/packages/backend/src/actors/project/db/migrations.ts
foundry/packages/backend/src/actors/project-branch-sync/index.ts
foundry/packages/backend/src/actors/project-pr-sync/index.ts
foundry/packages/frontend/src/components/workspace-dashboard.tsx

Client Impact

The repo overview screen should render cached rows immediately.
If the user requests a refresh, the UI should show a background sync indicator instead of waiting for the GET call to complete.
Polling frequency can be reduced because reads are now cheap and sync is event-driven.

Acceptance Criteria

getRepoOverview does not call force() on polling actors.
Opening the repo overview page does not trigger network/git work inline.
Slow branch sync or PR sync no longer blocks the page request.

Implementation Notes

Favor adding explicit freshness metadata over implicit timing assumptions in the frontend.
The overview query should remain safe to call frequently even if the UI still polls during the transition.
Fresh-agent check: confirm no other read paths call forceProjectSync() inline after this change.

3.1 KiB Raw Blame History