mirror of
https://github.com/harivansh-afk/sandbox-agent.git
synced 2026-04-22 05:00:49 +00:00
eacbc602e7
Refactors Foundry around organization/repository ownership and adds an organization-scoped GitHub state actor plus a user-scoped GitHub auth actor, removing the old project PR/branch sync actors and repo PR cache. Updates sandbox provisioning to rely on sandbox-agent for in-sandbox work, hardens Daytona startup and image-build behavior, and surfaces runtime and task-startup errors more clearly in the UI. Extends workbench and GitHub state handling to track merged PR state, adds runtime-issue tracking, refreshes client/test/config wiring, and documents the main live Foundry test flow plus actor coordination rules. Also updates the remaining Sandbox Agent install-version references in docs/examples to the current pinned minor channel. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
71 lines
3.1 KiB
Markdown
71 lines
3.1 KiB
Markdown
# Repo Overview Should Read Cached State Only
|
|
|
|
Read `00-end-to-end-async-realtime-plan.md` first for the governing migration order, runtime constraints, and realtime client model this brief assumes.
|
|
|
|
## Problem
|
|
|
|
Repo overview currently forces PR sync and branch sync inline before returning data. That turns a read path into:
|
|
|
|
- repo fetch
|
|
- branch enumeration
|
|
- diff/conflict calculations
|
|
- GitHub PR listing
|
|
|
|
The frontend polls repo overview repeatedly, so this design multiplies slow work and ties normal browsing to sync latency.
|
|
|
|
## Current Code Context
|
|
|
|
- Workspace overview entry point: `foundry/packages/backend/src/actors/workspace/actions.ts`
|
|
- Project overview implementation: `foundry/packages/backend/src/actors/project/actions.ts`
|
|
- Branch sync poller: `foundry/packages/backend/src/actors/project-branch-sync/index.ts`
|
|
- PR sync poller: `foundry/packages/backend/src/actors/project-pr-sync/index.ts`
|
|
- Repo overview client polling: `foundry/packages/frontend/src/components/workspace-dashboard.tsx`
|
|
|
|
## Target Contract
|
|
|
|
- `getRepoOverview` returns the latest cached repo projection immediately.
|
|
- Sync happens on a background cadence or on an explicit async refresh trigger.
|
|
- Overview responses include freshness metadata so the client can show "refreshing" or "stale" state without blocking.
|
|
|
|
## Proposed Fix
|
|
|
|
1. Remove inline `forceProjectSync()` from `getRepoOverview`.
|
|
2. Add freshness fields to the project projection, for example:
|
|
- `branchSyncAt`
|
|
- `prSyncAt`
|
|
- `branchSyncStatus`
|
|
- `prSyncStatus`
|
|
3. Let the existing polling actors own cache refresh.
|
|
4. If the client needs a manual refresh, add a non-blocking command such as `project.requestOverviewRefresh` that:
|
|
- enqueues refresh work
|
|
- updates sync status to `queued` or `running`
|
|
- returns immediately
|
|
5. Keep `getRepoOverview` as a pure read over project SQLite state.
|
|
|
|
## Files Likely To Change
|
|
|
|
- `foundry/packages/backend/src/actors/workspace/actions.ts`
|
|
- `foundry/packages/backend/src/actors/project/actions.ts`
|
|
- `foundry/packages/backend/src/actors/project/db/schema.ts`
|
|
- `foundry/packages/backend/src/actors/project/db/migrations.ts`
|
|
- `foundry/packages/backend/src/actors/project-branch-sync/index.ts`
|
|
- `foundry/packages/backend/src/actors/project-pr-sync/index.ts`
|
|
- `foundry/packages/frontend/src/components/workspace-dashboard.tsx`
|
|
|
|
## Client Impact
|
|
|
|
- The repo overview screen should render cached rows immediately.
|
|
- If the user requests a refresh, the UI should show a background sync indicator instead of waiting for the GET call to complete.
|
|
- Polling frequency can be reduced because reads are now cheap and sync is event-driven.
|
|
|
|
## Acceptance Criteria
|
|
|
|
- `getRepoOverview` does not call `force()` on polling actors.
|
|
- Opening the repo overview page does not trigger network/git work inline.
|
|
- Slow branch sync or PR sync no longer blocks the page request.
|
|
|
|
## Implementation Notes
|
|
|
|
- Favor adding explicit freshness metadata over implicit timing assumptions in the frontend.
|
|
- The overview query should remain safe to call frequently even if the UI still polls during the transition.
|
|
- Fresh-agent check: confirm no other read paths call `forceProjectSync()` inline after this change.
|